A couple fixes, oneliner each. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhanzhang3
commented
Mar 13, 2024
zhanzhang3
commented
- replace np.int() with int()
- add a condition check for detector change.
replace np.int() with int()
In function _currentDetectorChanged(), add condition:
if currentDetector != "":
self.updateROIandNumAvg()
In case the detector list is empty (e.g. when changing to a different detector config file, detSelect list will be cleaned out first), skip setting the ROI and others.
Not GUI interface entry added for this. Only for using with scripts. Very rudimentary, skipping the master file and only read the data file for the image. And the data file has to be organized similar as our .tiff file structure, under $(project_dir)/hdf5s/$(sample_name)/Snnn/.
Using json file as input. 2 input files are uploaded, too.
Keep them here for display slices of vti files. But it could be very Paraview version dependent. One is doing X, Y, Z slice through a point; the other tiling multiple vti file side by side with a single slice from each file.
Edit the output message showing Qx, Qy, Qz to Qx/H, Qy/K, Qz/L, as we use HKL more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.