Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'type' attribute from Tab's attributes, as it is invalid type. #106

Conversation

TuVanDev
Copy link
Contributor

@TuVanDev TuVanDev commented Sep 5, 2023

Purpose of this pull request

This pull request (PR) aims to remove the 'type' attribute from Tab's attributes, as it is invalid type on the "system.xml reference" page

Fixes #105

Affected pages

Reference:
vendor/magento/module-config/etc/system_file.xsd

<xs:element name="tab">
    <xs:annotation>
        <xs:documentation>
            Tab resource. Recursive complex type.
        </xs:documentation>
    </xs:annotation>

    <xs:complexType>
        <xs:sequence>
            <xs:element maxOccurs="1" name="label" type="xs:string" />
        </xs:sequence>
        <xs:attributeGroup ref="tabAttributeGroup"/>
    </xs:complexType>
</xs:element>

tabAttributeGroup is declared as the following

<xs:attributeGroup name="tabAttributeGroup">
    <xs:attribute name="id" type="typeId" use="required" />
    <xs:attribute name="translate" type="xs:string" use="optional" />
    <xs:attribute name="sortOrder" type="xs:float" use="optional" />
    <xs:attribute name="class" type="xs:string" use="optional" />
</xs:attributeGroup>

Therefore, we can confirm that the 'type' attribute is invalid attribute.

@hguthrie hguthrie added the editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Sep 7, 2023
@adobe-bot adobe-bot merged commit 6aa4f1f into AdobeDocs:main Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Config guide: system.xml Tab type options need review
3 participants