-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhcp offer ip by client id in dhcpv4 #6110
base: master
Are you sure you want to change the base?
Conversation
Hi @nmreadelf, sorry for the late reply and thanks for the contribution. As far as I know, RFC-4361 Section 6.1, which updates the referenced RFC-2132, actually forbids using the hardware address in option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment.
relate #6135 |
@EugeneOne1 @ainar-g hello, i resolve merge conflicts, can you make approve again? |
@EugeneOne1 @ainar-g hello, Could you please assist in merging this pull request? It has been open for close to a year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmreadelf, good afternoon and apologies for late review. The reactions to the issue proposing this change seem to not have demonstrated the need for it. In addition, you never responded to our concerns about the standard's recommendations. So, we are not ready to merge this change.
You can always keep this feature in your personal fork of AdGuard Home.
I have configured a virtual machine that utilizes the host network on my physical machine. Upon examination, I discovered that the AdGuard Home server being hosted offers IP addresses based on the MAC address of the physical host machine rather than the virtual machine itself. Specifically, the actual MAC address of the virtual machine is present in the client-id field of DHCP requests. For proper functionality, the DHCP server should be offering IP addresses based on the client-id field, which contains the MAC address of the virtual machine. This would allow the DHCP server to correctly identify the virtual machine and provide it an IP address accordingly. The current behavior indicates a misconfiguration, where the DHCP server is assigning IP addresses using the physical host's MAC address instead of the virtual machine client's MAC address contained in the DHCP request.
resolve #6135