Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide signal messages in chats #701

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: hide signal messages in chats #701

merged 1 commit into from
Jan 29, 2025

Conversation

S-FrontendDev
Copy link
Collaborator

No description provided.

@S-FrontendDev S-FrontendDev requested a review from bludnic January 27, 2025 16:20
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 4:37pm

Copy link

github-actions bot commented Jan 27, 2025

Deployed to https://msg-adamant-pr-701.surge.sh 🚀

@S-FrontendDev
Copy link
Collaborator Author

@bludnic
Copy link
Member

bludnic commented Jan 28, 2025

I think the issue is that we push the message locally to the chat, so if you refresh the page, the Signal Message will disappear. This means that the nodes don't return Signal Messages neither via WS or REST.

@yoxira can you confirm that these endpoints don't return Signal Messages?

  • WS socket('newMessage', (transaction) => {})
  • GET /api/chats/get

@yoxira
Copy link
Member

yoxira commented Jan 28, 2025

@bludnic

  • /api/chats/get doesn't return signal messages unless you directly use ?type=3 parameter. Note: because the endpoint always return chat message transactions, type parameter means asset.chat.type
  • Node doesn't emit newMessage event. It's a client event (See https://github.com/Adamant-im/adamant-im/blob/dev/src/lib/sockets.js#L152). newTrans event does return all transactions by default, including signal messages.

@bludnic bludnic merged commit 7df633e into dev Jan 29, 2025
3 checks passed
@bludnic bludnic deleted the fix/push-signals branch January 29, 2025 17:24
Copy link

Successfully tore down https://msg-adamant-pr-701.surge.sh 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants