[trello.com/c/rxAVDtVH]: EthWalletService tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeretennikovSV
approved these changes
Jan 17, 2025
just-software-dev
approved these changes
Jan 22, 2025
ChrisBenua
force-pushed
the
dev/trello.com/c/rxAVDtVH
branch
from
bbfc161 to
6e98454
Compare
ChrisBenua
force-pushed
the
dev/trello.com/c/rxAVDtVH
branch
from
6e98454 to
79666b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for
EthWalletService.Because Web3Core uses raw URLSession calls for networking, so I've done mocking and tracking request using
URLProtocolinMockURLProtocol. I set customURLSessionwith custom configuration withMockURLProtocolthroughWeb3ProviderMock. For correct checking request body and response body, addedEthRequestBodyfor request bodies andEthAPIResponse.To proxy
Ethcalls, addedIEthMock. All default logic ofIEthprotocol is located in extension:IEth+Defaults, so for calling original implementation addedEthDefaultclass.PR is opened in branch with tests for
BTCWalletServiceto reduce reviewed diff. After BTCWalletService PR will be merge, I will change branch to develop