Zoisite - Jackie Aponte #40
Conversation
…movies in the user's watch list and a function to get the user's most watched genre.
… returns a list of the movies the user has watched that their friends haven't watched. Includes a function get_friends_unique_movies that returns a list of movies the user's friends have watched that they haven't watched. test_wave_03 updated. test_friends_unique_movies_not_duplicated also tests to make sure the correct movies are returned from get_friends_unique_watched.
…ecommended movies from friends watched movies if the user is subscribed to the movie's host and the user hasn't watched the movie yet.
…recommendations for the user if their friends have watched it and the movie genre is the most watched genre by user. the function get_rec_from_favorites returns a list of movies the user recommends if their friends haven't watched it and it is in their favorites list. The test test_new_genre_rec_from_empty_friends is completed.
There was a problem hiding this comment.
Nice job on Viewing Party, Jackie!
Your project shows that you're getting more fluent with working with nested data structures, iterating over them, and using conditional logic.
Nice job making frequent commits with descriptive commit messages!
Let me know if you have any questions.
| assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1 | ||
| assert updated_data["watched"][0]["genre"] == GENRE_1 | ||
| assert updated_data["watched"][0]["rating"] == RATING_1 |
| assert movie_to_watch not in updated_data["watchlist"] | ||
| assert movie_to_watch in updated_data["watched"] | ||
| assert FANTASY_2 in updated_data["watched"] |
| assert len(recommendations) == 0 | ||
| assert not recommendations | ||
| assert recommendations == [] |
There was a problem hiding this comment.
I'd only do one of these checks. assert recommendations == [] checks that the result is an empty list, while assert len(recommendations) == 0 checks only that recommendations is something reporting a length of 0.
If you really want to be sure that the return value is truly a list, then go with == [], but I'd tend towards the latter (we tend to be a little loose with types in Python).
|
|
||
| if not (title and genre and rating): | ||
| return None | ||
| else: |
There was a problem hiding this comment.
No need for this else statement. When possible we should try not to write extra statements or creating nesting when we don't need them to avoid bugs.
Also, we can directly return a literal dictionary without referencing it with a variable, like:
return { "title" : title, "genre" : genre, "rating" : rating}
| rating_list = [] | ||
| if not user_data["watched"]: | ||
| return 0.0 |
There was a problem hiding this comment.
Consider adding a guard clause before line 41 because we don't need rating_list` if we're going to return 0.0 when the watched list is empty.
| for friend in user_data["friends"]: | ||
| for movie in friend["watched"]: | ||
| if movie["title"] not in friends_watched_titles: |
There was a problem hiding this comment.
Consider pulling this into a helper function, maybe like get_friends_movies()
| if movie["title"] == title: | ||
| user_unique_movies.append(movie) | ||
|
|
||
| return user_unique_movies |
There was a problem hiding this comment.
Another way to approach this problem would be to use sets. You could create a set of a set of a friend's watched titles.
for movie in user_data["watched"]:
if movie["title"] not in friends_watched_set:
user_unique_movies.append(movie) return unique_list| for title in friends_unique_titles: | ||
| for friend in user_data["friends"]: | ||
| for movie in friend["watched"]: | ||
| if movie["title"] == title and movie not in friends_unique_movies: | ||
| friends_unique_movies.append(movie) |
There was a problem hiding this comment.
When I see many for loops nested like this, I think about how we could pull values into variables so we don't get deeply indented levels of code. For example, instead of needing two for loops to get into friends' movies, could you create a list of all friends movies before this and then use that list here to save on a for loop?
Also, consider how you could use sets here too because you have for loops using the in operator on lists which can quickly lead to quadratic or even cubic time complexity.
You could create a set of user's watched movie titles and have the inverse logic of get_unique_watched.
|
|
||
| # ----------------------------------------- | ||
| # ------------- WAVE 4 -------------------- | ||
| # ----------------------------------------- | ||
|
|
||
| def get_available_recs(user_data): | ||
|
|
||
| friends_recommended_movies = get_friends_unique_watched(user_data) |
There was a problem hiding this comment.
Nice job reusing a method you already wrote.
| for movie in friends_recommended_movies: | ||
| if movie["host"] in user_data["subscriptions"]: |
There was a problem hiding this comment.
What's the time complexity of a for loop that has to execute the in operator on a list during every iteration?
We could improve the subscription lookup if we trade a little space and make a set of the subscriptions (which are strings, so can go in a set). Using in on a list is a linear operation, but on a set, it's constant.
subscriptions = set(user_data["subscriptions"])
for movie in friends_recommended_movies:
if movie["host"] in subscriptions:
recommended_movies.append(movie)
No description provided.