Panthers - Cintia Shamsu #29
Conversation
There was a problem hiding this comment.
Great work Cintia! You hit all the learning goals for this project and all tests are passing. Your code was very clean and well-organized. You have earned a well-deserved 🟢 grade on this project 🐈⬛ ✨
I added comments to your PR primarily on ways to add list comprehension to refactor your code. In the future, I'd like to see you use more guard clauses and docstrings in your functions. Docstrings are a great way of leaving notes to your future self about your approach to writing these functions (especially about how mean and mode work).
Feel free to refactor and improve on this project and do let me know if you want me to take another look for fun 😄
| assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1 | ||
| assert updated_data["watched"][0]["genre"] == GENRE_1 | ||
| assert updated_data["watched"][0]["rating"] == RATING_1 | ||
| assert updated_data["watchlist"] == [] |
There was a problem hiding this comment.
👍 Nice work! I would remove the last test as the first test of checking if the watchlist is empty is sufficient enough.
| assert updated_data["watched"][1] == movie_to_watch | ||
| assert updated_data["watched"][0] == FANTASY_2 |
| assert INTRIGUE_3 in friends_unique_movies | ||
| assert FANTASY_4 in friends_unique_movies | ||
| assert HORROR_1 in friends_unique_movies |
| # Act | ||
| result = get_new_rec_by_genre(sonyas_data) | ||
|
|
||
| # Assert | ||
| assert len(result) == 0 |
| if title == None or genre == None or rating == None: | ||
| return None | ||
| else: | ||
| movie = {"title" : title, "genre" : genre, "rating" : rating} | ||
| return movie |
There was a problem hiding this comment.
What happens if title, genre, or rating were entered as empty strings, 0, or False? We can make your conditional more robust by checking for all falsey values instead. The else clause is also optional here and we can omit it, allowing the creation of the movie dictionary to shine and be more in focus.
if not title or not genre or not rating:
return None
movie = {"title" : title, "genre" : genre, "rating" : rating}
return movie| def get_user_data(user_data): | ||
| self = [] | ||
| for data in user_data["watched"]: | ||
| if data not in self: | ||
| self.append(data) | ||
| return self |
There was a problem hiding this comment.
👍 Nice work preventing duplicate movies from being added to the list.
| def get_unique_watched(user_data): | ||
| unique = [] | ||
| friends = get_friend_data(user_data) | ||
| user = get_user_data(user_data) | ||
| for movie in user: | ||
| if movie not in friends: | ||
| unique.append(movie) | ||
| return unique |
There was a problem hiding this comment.
👍 Nice helper functions!
| def get_friends_unique_watched(user_data): | ||
| unique = [] | ||
| friends = get_friend_data(user_data) | ||
| user = get_user_data(user_data) | ||
| for movie in friends: | ||
| if movie not in user: | ||
| unique.append(movie) | ||
| return unique |
There was a problem hiding this comment.
👍 Nice helper functions, again!
| def get_available_recs(user_data): | ||
| recs = [] | ||
| friends = get_friend_data(user_data) | ||
| user = get_user_data(user_data) | ||
| for movie in friends: | ||
| if movie not in user: | ||
| if movie["host"] in user_data["subscriptions"]: | ||
| recs.append(movie) | ||
| return recs |
There was a problem hiding this comment.
👍 Nice work! We can use combined conditional expressions to combine the two if statements:
def get_available_recs(user_data):
recs = []
friends = get_friend_data(user_data)
user = get_user_data(user_data)
for movie in friends:
if movie not in user and movie["host"] in user_data["subscriptions"]:
recs.append(movie)
return recs| def get_new_rec_by_genre(user_data): | ||
| recs = [] | ||
| user = get_user_data(user_data) | ||
| friends = get_friend_data(user_data) | ||
| fave = get_most_watched_genre(user_data) | ||
| for movie in friends: | ||
| if movie not in user and movie["genre"] == fave: | ||
| recs.append(movie) | ||
| return recs | ||
|
|
||
| # Recommends movies from user's fav list that no friends have watched | ||
| def get_rec_from_favorites(user_data): | ||
| recs = [] | ||
| friends = get_friend_data(user_data) | ||
| fave = user_data["favorites"] | ||
| for each in fave: | ||
| if each not in friends: | ||
| recs.append(each) | ||
| return recs |
There was a problem hiding this comment.
👍 Great work utilizing helper functions in both of these functions. How would we use list comprehensions to clean up our code?
No description provided.