C18 Panthers Class[ Brooke Hill ] #26

brookestrz · 2022-09-21T22:31:37Z

No description provided.

audreyandoy

Hey brooke, here is the feedback we walked through during our 1:1. More is coming! Let me know if you have any questions.

audreyandoy · 2022-09-28T15:15:16Z

viewing_party/party.py

+from ast import If
+from types import NoneType


I don't think you need these imports. Please remove these floaty, random bits in future PRs.

audreyandoy · 2022-09-28T15:15:52Z

viewing_party/party.py

+
+

One space is sufficient to create 'sections' of logic within functions.

audreyandoy · 2022-09-28T15:20:32Z

viewing_party/party.py

+    movie = {}
+
+    movie["title"] = movie_title
+    movie["genre"] = genre
+    movie["rating"] = rating
+
+    for item in movie.values():
+        if item == None:
+            return None
+    else:
+        return movie


if not movie_title or not genre or not rating: return None return { "title": movie_title, "genre": genre, "rating": rating }

audreyandoy · 2022-09-28T15:23:16Z

viewing_party/party.py

+    user_data = {
+    "watched": []
+    }   
+    copy = movie.copy()


If we want to copy the nested items within a nested data structure, we should use deepcopy. copy only copies the outer layer.

audreyandoy · 2022-09-28T15:24:27Z

viewing_party/party.py

+def watch_movie(user_data, title):
+
+
+
+    for movie in user_data["watchlist"]:
+        if title == movie['title']:
+            user_data["watched"].append(movie)
+            user_data["watchlist"].remove(movie)
+    return user_data
+
+
+
+
+
+
+
+


Brooke, mind your space! Please take up space everywhere in life, except in your functions LOL. One line of blank space is enough.

LOL I wrote this with you during our 1:1 and we were giggling together but reading this afterward is WOWW.... so sassy 🤣 I swear I'm not this blunt LOL

audreyandoy · 2022-09-28T15:26:16Z

viewing_party/party.py

+    if sum != 0:
+        avg = sum / count
+    else:
+        avg = 0.0


if sum == 0: return 0.0 avg = sum / count

audreyandoy · 2022-09-28T15:28:20Z

viewing_party/party.py

+def get_most_watched_genre(user_data):
+# will come back to this one to handle all test cases
+    for movie in user_data["watched"]:
+        if movie["genre"] == movie["genre"]:
+            return movie["genre"]
+        elif len(user_data["watched"]) == 0:
+            return None


Hey Brooke, revisit this and I'll provide feedback 😄

Approaches we discussed:

Creating a counter based off of the genres and whichever has the higher count return that

Creating a counter and a most_freq with each iteration increase count and most_freq

(BEST approach, audrey highly suggests) Use a frequency map! Create a dictionary with the genres as a key and the values as their 'count' aka frequency.

audreyandoy

Great work Brooke! You hit all the learning goals for this project and all tests are passing. You have earned a well-deserved 🟢 grade on this project 🐈‍⬛ ✨

I added comments to your PR primarily on ways to refactor your code and improve readability. In the future, I'd like to see you use more guard clauses and docstrings in your functions. Docstrings are a great way of leaving notes to your future self about your approach to writing these functions.

Feel free to refactor and improve on this project and do let me know if you want me to take another look for fun 😄

Keep up the great work! ✨

audreyandoy · 2022-09-30T15:44:46Z

tests/test_wave_01.py

+    assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1
+    assert updated_data["watched"][0]["genre"] == GENRE_1
+    assert updated_data["watched"][0]["rating"] == RATING_1


👍 We don't need to add spaces between these asserts

Suggested change

assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1

assert updated_data["watched"][0]["genre"] == GENRE_1

assert updated_data["watched"][0]["rating"] == RATING_1

assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1

assert updated_data["watched"][0]["genre"] == GENRE_1

assert updated_data["watched"][0]["rating"] == RATING_1

audreyandoy · 2022-09-30T15:45:15Z

tests/test_wave_01.py

    # Assert
    assert len(updated_data["watchlist"]) == 1
    assert len(updated_data["watched"]) == 2

-    raise Exception("Test needs to be completed.")
+    #raise Exception("Test needs to be completed.")


I think you're missing an assert for this test but no worries, we can go over it during a 1:1.

audreyandoy · 2022-09-30T15:45:40Z

tests/test_wave_03.py

+    assert INTRIGUE_3 in friends_unique_movies
+    assert HORROR_1 in friends_unique_movies
+    assert FANTASY_4 in friends_unique_movies                      # **************************************************************************************************


👍 Good work utilizing the in operator. Also, no need for spaces here as well.

audreyandoy · 2022-09-30T15:46:15Z

tests/test_wave_05.py

+    recommendations = get_new_rec_by_genre(sonyas_data)
+   #raise Exception("Test needs to be completed.")
+    assert len(recommendations) == 0                                              #*********************************************************************


audreyandoy · 2022-09-30T15:51:48Z

viewing_party/party.py

+def add_to_watchlist(user_data, movie):
+    user_data = {
+        "watchlist": []
+    }
+    copy1 = movie.copy()
+
+    user_data["watchlist"].append(copy1)
+
+    return user_data


👍

A few suggestions:

copy1 is a very generic name. I recommend using a more descriptive name like watchlist_copy.

In the first line of the function, you're actually reassigning user_data to be a brand new dictionary with an empty watchlist. The watchlist is actually already provided via the user_data parameter.

audreyandoy · 2022-10-02T01:08:27Z

viewing_party/party.py

+# Add genre counts to a dictionary with value being how many times the genre appears in a list.
+    for genre in list_of_genres:
+        genres[genre] = genres.get(genre,0) + 1


Nice use of get !

audreyandoy · 2022-10-02T01:10:13Z

viewing_party/party.py

+# getting highest value from dict
+    new_val = genres.values()
+    if len(new_val) > 0:
+        max_val = max(new_val)
+    for genre in genres:
+        if genres[genre] == max_val:
+            most_watched_genre = genre


We can reuse get_most_watched_genre as a helper function here.

audreyandoy · 2022-10-02T01:11:13Z

viewing_party/party.py

+    for movie in user_data["friends"][0]["watched"]:
+        friends_list.append(movie)
+    for movie in user_data["friends"][1]["watched"]:
+        friends_list.append(movie)


Same comment as in the previous function about considering scalability.

audreyandoy · 2022-10-02T01:11:19Z

viewing_party/party.py

+    for movies in friends_list:
+        if movies not in user_data["watched"] and movies["genre"] == most_watched_genre:
+            new_recs.append(movies)
+    return new_recs


audreyandoy · 2022-10-02T01:15:17Z

viewing_party/party.py

+def get_rec_from_favorites(user_data):
+    user_favorites = []
+    friend_list = []
+    movie_recs = []
+
+
+    for movies in user_data["favorites"]:
+        user_favorites.append(movies)
+    if len(user_data["friends"]) > 0:
+        for friends in user_data["friends"][0]["watched"]:
+            friend_list.append(friends)
+        for friends in user_data["friends"][1]["watched"]:
+            friend_list.append(friends)
+
+    for movies in user_favorites:
+        if movies not in friend_list:
+            movie_recs.append(movies)
+    return movie_recs


👍 Nice work! We can use a guard clause here to allow the logic for building friend_list to be less indented.

def get_rec_from_favorites(user_data): user_favorites = [] friend_list = [] movie_recs = [] if not user_data or not user_data["friends"]: return for movies in user_data["favorites"]: user_favorites.append(movies) for friends in user_data["friends"][0]["watched"]: friend_list.append(friends) for friends in user_data["friends"][1]["watched"]: friend_list.append(friends) for movies in user_favorites: if movies not in friend_list: movie_recs.append(movies) return movie_recs

brookestrz added 2 commits September 21, 2022 15:12

viewing-party done

8881558

my viewing-party

e6e4ac8

audreyandoy reviewed Sep 28, 2022

View reviewed changes

audreyandoy reviewed Oct 2, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C18 Panthers Class[ Brooke Hill ] #26

C18 Panthers Class[ Brooke Hill ] #26

brookestrz commented Sep 21, 2022

audreyandoy left a comment

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 30, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy Sep 28, 2022

audreyandoy left a comment

audreyandoy Sep 30, 2022

audreyandoy Sep 30, 2022

audreyandoy Sep 30, 2022

audreyandoy Sep 30, 2022

audreyandoy Sep 30, 2022

audreyandoy Oct 2, 2022

audreyandoy Oct 2, 2022

audreyandoy Oct 2, 2022

audreyandoy Oct 2, 2022

audreyandoy Oct 2, 2022

C18 Panthers Class[ Brooke Hill ] #26

Are you sure you want to change the base?

C18 Panthers Class[ Brooke Hill ] #26

Conversation

brookestrz commented Sep 21, 2022

audreyandoy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audreyandoy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment