Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Marisol Lopez - Scrabble.js #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

marisol-lopez
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I used a lot of loops to get through a lot of the requirements
What was a challenge you were able to overcome on this assignment? Conditionals for all of the requirements for the array of words.
What is your favorite thing about learning a new programming language? I liked Javascript, it's frustrating when I forget a bracket but I like that I know what is going on for the most part.
What is your least favorite thing about learning a new programming language? Confusing another language's syntax with a new one
Do you have any recommendations on how we could improve this project for the next cohort? More emphasis on prototype

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Mostly good - commits have more than one feature complete, should be split up into their own commit
Comprehension questions Well Done - and thanks for the feedback!
General
score calculates score, has appropriate params and return value Well Done
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well Done
Has highestScoringWord and highestWordScore functions ❗️ HighestScoringWord is returning the score and not the word, which seems like the intention of Scrabble's highestScoreFrom function, but not this one (judging by the naming of the variables) seems like it has the intention of returning the word. That's why highestWordScore isn't working correctly. Doesn't appear to be handling ties.
Overall
The project had a strong start but seemed to loose steam when it came to the logic of determining the highest scoring word from the array of plays. Which led to the rest of the functionality not being able to work. I recommend sitting down and revisiting Scrabble.prototype.highestScoreFrom to return the word. It's a worthy fix that will be beneficial to go back to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants