Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kelly Souza JS-Scrabble #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kellysouza
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Duck typing!
What was a challenge you were able to overcome on this assignment? I wanted to not rewrite the same methods multiple times. I wanted the highest scoring word method to not care whether the data passed to it was from the player or the game, so I created helper methods.
What is your favorite thing about learning a new programming language? It's like putting together puzzle pieces or a cryptogram!
What is your least favorite thing about learning a new programming language? having to look EVERYTHING up. even the basic stuff.
Do you have any recommendations on how we could improve this project for the next cohort? No, I think it was good practice to apply new language skills to a relatively familiar project.

};

Player.prototype.hasWon = function () {
if (this.totalScore() >= 100) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also be written return this.totalScore() >= 100;

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Check
Comprehension questions Duck Typing!!
General
score calculates score, has appropriate params and return value Nice use of helper methods.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Not quite the method from the instructions, but it works well and is a smidge more efficient for the program.
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check, good use of existing functions
Overall Nicely done, good variation on the assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants