stacks - Jackie - scrabble

[jackiewatanabe]

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	I was able to use looping patterns and arrays as well as hash-like objects. Also had to look up a function similar to Ruby's .downcase method.
What was a challenge you were able to overcome on this assignment?	Figuring out and remembering when to put () after a function when calling it.
What is your favorite thing about learning a new programming language?	remembering concepts from the other language and trying to look up similar concepts in the new language
What is your least favorite thing about learning a new programming language?	forgetting syntax differences and getting really stuck because of them
Do you have any recommendations on how we could improve this project for the next cohort?	I think it was unclear on how we were supposed to set up Scrabble and its functions as kind of class methods. I originally had a Scrabble constructor and a scrabble protoype, but it wasn't until I spoke with other classmates that I was tipped off on doing it the way I currently did it.

[CheezItMan]

You could also do:

return this.totalScore() > 100; and leave off the if.

[CheezItMan]

JS Scrabble

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	2 commits.... one of which is commenting out unnecessary code...
Comprehension questions	Check, thank for the comment about object & class methods.
General
score calculates score, has appropriate params and return value	Check, well done!
highestScoreFrom calculates highest scoring word, has appropriate params and return value	Why call Scrabble.score twice potentially. There is some unnecessary calculation in here. For example if the highest scoring word is the 1st word of a 10 word array, you'll call Scrabble.score on it 11 times.
Player object
Has name and plays properties	Check, plus tiles!
Has play, totalScore, hasWon functions	Check, hasWon could be slimmer, but this works.
Has highestScoringWord and highestWordScore functions	Check, good use of existing functions.
Overall	Nicely done, pay a little attention as noted to ways to slim down your code and reduce unnecessary calculation, but it's well done. It look like you got well on the way through the options.