Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC's JS Scrabble #36

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

AC's JS Scrabble #36

wants to merge 8 commits into from

Conversation

acgillette
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Using similar control flow with loops and iterations, and just generally knowing how to structure programs.
What was a challenge you were able to overcome on this assignment? Figuring out javascript scope. I realized I couldn't use an instance variable inside an anonymous forEach function. Thankfully it turned out there was a way to pass in this variables.
What is your favorite thing about learning a new programming language? I like learning new ways of thinking and new ways of structuring code!
What is your least favorite thing about learning a new programming language? Figuring out all the weird quirks a language has
Do you have any recommendations on how we could improve this project for the next cohort? No, I thought it was a good level of challenge.

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Having your score chart set up this requires you do to iterations that you wouldn't have to do if your chart was set up differently - could improve efficiency with a different structure. Nice job figuring out how to scope this within your forEach function.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Looks good
Player object
Has name and plays properties Yes - good
Has play, totalScore, hasWon functions I think the specs for the play function want you to return false if the word isn't played (rather than a string). totalScore and hasWon look good. Nice use of the ternary.
Has highestScoringWord and highestWordScore functions Good
Overall Nice job hitting the major learning goals, exploring some corners of JS scope and practicing syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants