Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ann's JS Scrabble #31

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ann's JS Scrabble #31

wants to merge 7 commits into from

Conversation

gofarann
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to use datatypes like hashes and arrays; additionally, I was able to use for loops a lot. I don't think these are unique to ruby, but it was helpful to recognize what was needed and research the application in a new language.
What was a challenge you were able to overcome on this assignment? The board was hard. It was hard to grasp in my mind how the coordinates applied to positions on the board. Ultimately, I was able to place a starting point on the board.
What is your favorite thing about learning a new programming language? All of it! Doing research and understanding more tings on StackOverflow.
What is your least favorite thing about learning a new programming language? knowing how much I don't know.
Do you have any recommendations on how we could improve this project for the next cohort? Perhaps instead of adding more functions to optional requirements like boards, the optional could be to make a working game with prompts.

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value With the score chart structured this way, it makes looking up each letters score a much slower process. (Nice job using Object.keys though!) I think it would be good to structure the way your tilebag is structured instead.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Yes - good
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes - watch your indentation! You're using the Scrabble's score variable, but I think it might make more sense to have a variable within the Player object rather than Scrabble. What will your hasWon function do if the user hasn't yet won?
Has highestScoringWord and highestWordScore functions Yes - good job using the Scrabble functions here
Overall Nice job doing some of the optionals and covering the major learning goals on this assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants