Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lynn Trickey's JS Scrabble #30

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Lynn Trickey's JS Scrabble #30

wants to merge 10 commits into from

Conversation

ltrickey
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Lots of the loops are similar in terms of what they're accomplishing.
What was a challenge you were able to overcome on this assignment? READING CSV FILEZZZ.
What is your favorite thing about learning a new programming language? It's exciting to pick it up so much more quickly because of the basic knowledge of programming stuffs!
What is your least favorite thing about learning a new programming language? Minor syntactical errors that put me in a tailspin. Damn you var!
Do you have any recommendations on how we could improve this project for the next cohort? Maybe have a little more instruction on how to use input so we could incorporate that into this and make a working game!

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good git hygiene.
Comprehension questions Check, good that you were able to figure out input and CSV files, nicely done!
General
score calculates score, has appropriate params and return value Well done, good use of the JS object as a hash.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Good clean if statements
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Nice use of the tiles to check to see if the user could play it. That might be a good case for a helper method.
Has highestScoringWord and highestWordScore functions You could use highestWordScore in the highestScoringWord function.
TileBag Nice work setting up the Tilebag although maybe, startGame could be a constructor instead?
Overall You could have dropped .prototype for Scrabble because you'll only ever need 1 Scrabble object. Think of it like a set of class methods. I like all the testing you put into it. It shows good practices. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants