Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Tamiko Terada - js-scrabble #26

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

TamikoT
Copy link

@TamikoT TamikoT commented May 18, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to apply my grasp of iterating across different data types from Ruby to do things like look at each character of a string or each word of an array in JS.
What was a challenge you were able to overcome on this assignment? It was a challenge to shift gears from classes in namespaces (in Ruby) to functions and prototypes (in JS). I originally thought that everything had to fit within the Scrabble function which helped me learn a lot about what NOT to do.
What is your favorite thing about learning a new programming language? I like trying to spot the differences. I feel that making comparisons between the two helps me have a better understanding of both the "new" language and the "old" one.
What is your least favorite thing about learning a new programming language? I definitely miss knowing about all of the debugging tools and tests in Ruby and see that there will be a learning curb to getting to a point where I can debug things efficiently but I guess it's only been 3 days...
Do you have any recommendations on how we could improve this project for the next cohort? I think naming the Scrabble object something like "Scoring" might be more reflective of what the object is actually doing and help guide people down the right path as far as setting up the relationships between the scoring functionality and players. Other than that, it was fun to revisit and old assignment with a new language~!

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done - thanks for the feedback and perspective!
General
score calculates score, has appropriate params and return value Well Done - Nice way of defining scores for each letter, however - should that score_hash object be defined in the function? That means it'd be created every time the function is called. Instead, it would be more efficient to have it defined as a property of the scrabble object.
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well done - nice use of new function, max_score to clean up this function.
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions ❗️ Missing total score - play and hasWon well done
Has highestScoringWord and highestWordScore functions Well done
Overall
totalScore function is missing. All other required functionality is complete and meets expectations of the project.

@TamikoT
Copy link
Author

TamikoT commented May 23, 2017

The total score is set as var score in the Player constructor and within Player.play() it adds to that total score--so it can be accessed with playerobj.score() at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants