Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haby's Scrabble #22

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Haby's Scrabble #22

wants to merge 15 commits into from

Conversation

habypsow
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? There are some similar methods, such as 'push', or the forEach loops, that are similar to what I used in Ruby. I just needed to look up the correct syntax.
What was a challenge you were able to overcome on this assignment? Knowing how to google / read Javascript documentation to get needed information.
What is your favorite thing about learning a new programming language? Learning the patterns, and seeing that there are a lot of things that do already seem familiar, even though I never used them in the new language.
What is your least favorite thing about learning a new programming language? Probably not knowing how to do something that I find easy to do in Ruby. For example, I am still very hazy on how to use hashes / methods with hashes in Javascript currently.
Do you have any recommendations on how we could improve this project for the next cohort? None that I can think of :)

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Looks good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Yes - good
highestScoreFrom calculates highest scoring word, has appropriate params and return value When you create a function off of the prototype on the object, you want to call the function using an instance. What I mean is you'll want some var s = new Scrabble(); to create an instance, then use that instance to call the score method s.score("word"). By using the Scrabble's prototype directly, you're using a strategy that works but that we don't really want to utilize. I see you demonstrated the correct way to use the functions in the Player obj.
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes
Has highestScoringWord and highestWordScore functions Good - watch out for indentation
Overall Good job practicing your syntax and hitting the major learning goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants