Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addie's JS Scrabble #16

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

add2point71dots
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I started thinking about functions attached to a prototype vs attached to the constructor as similar to ruby instance methods vs class methods. I'm sure this won't make sense in all situations, but it helped me get my head around defining functions in this project.
What was a challenge you were able to overcome on this assignment? I got a lot of practice with where semicolons go and don't go!
What is your favorite thing about learning a new programming language? I think learning a new syntax, and discovering all the little quirks of a new language, is fun!
What is your least favorite thing about learning a new programming language? Hmm, I can't think of anything specific.
Do you have any recommendations on how we could improve this project for the next cohort? Nothing in particular!

@kariabancroft
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Yes - nice job using the "class-like" function syntax
highestScoreFrom calculates highest scoring word, has appropriate params and return value I like the way you used bool vars to store specific logic you wanted to check - adds a good amount of clarity overall
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes
Has highestScoringWord and highestWordScore functions Yes
Overall Nice job hitting the major learning goals of this assignment as well as exploring some optionals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants