forked from AdaGold/video-store-consumer
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Janice and Theresa's Video Store #8
Open
TheresaManney
wants to merge
31
commits into
Ada-C7:master
Choose a base branch
from
janicewilson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamled
added a commit
to Ada-Developers-Academy/classroom-app
that referenced
this pull request
Jul 10, 2017
When GitHub has a PR made from a repository/fork that has been deleted it shows "unknown repository" as the source on the [PR page][1] and the API does not include any repo information for the "head" section of the PR data. We now check whether that information is available from the API and effectively ignore the PR if it does not exist. My understanding is that this means the submission line for each associated student will continue to be listed as unsubmitted, however I do not have a good test case for this situation. This fix only applies to the logic for group projects as the individual project does not require the same repo information. Note: The safety check code that I've put in the `contributors_url` method could be cleaned up a bit if we switch to Ruby 2.3.0 or later, which supports `Hash#dig` for exactly this purpose. [1]: Ada-C7/VideoStoreConsumer#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Store Consumer
Congratulations! You're submitting your assignment!
Comprehension Questions