Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janice and Theresa's Video Store #8

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Janice and Theresa's Video Store #8

wants to merge 31 commits into from

Conversation

TheresaManney
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Theresa learned how to console log more frequently when stuck and confused in backbone. Janice learned some foundational basics.
What was one area of Backbone you gained more clarity on during this assignment? We learned about nested views along with a better understanding that everything (including views) is an object in backbone and can be tossed around via javascript functions.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We created different collections to separate the local api from the external api, we also changed the colors of the containers of both so that we could see the difference between external movies and local movies when searching before adding.
Describe a DOM event your application handled When the document loaded the movies view initializes.
Describe a custom event your application handled When the 'Add Movie' button is clicked, it then triggers the database model to be saved as a movie model.
Do you have any recommendations on how we could improve this project for the next cohort? It might have been nice to have more to do on the Rails side so there is more opportunity to get a rails refresher. We both really liked this project overall, having two servers running at once was something new for all of us and it felt very powerful and was cool to experience overall.

TheresaManney and others added 30 commits June 13, 2017 15:27
Hamled added a commit to Ada-Developers-Academy/classroom-app that referenced this pull request Jul 10, 2017
When GitHub has a PR made from a repository/fork that has been deleted
it shows "unknown repository" as the source on the [PR page][1] and the
API does not include any repo information for the "head" section of the
PR data.

We now check whether that information is available from the API and
effectively ignore the PR if it does not exist. My understanding is that
this means the submission line for each associated student will continue
to be listed as unsubmitted, however I do not have a good test case for
this situation.

This fix only applies to the logic for group projects as the individual
project does not require the same repo information.

Note: The safety check code that I've put in the `contributors_url`
method could be cleaned up a bit if we switch to Ruby 2.3.0 or later,
which supports `Hash#dig` for exactly this purpose.

[1]: Ada-C7/VideoStoreConsumer#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants