-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maple - Christine #31
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐶🐾 Nice work, Christine! I left one comment suggesting some refactoring to address an edge case, but overall it looks like you hit the learning goals for this project. Let me know what questions you have.
🟢
Time Complexity: O(N + E) | ||
Space Complexity: O(N) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
if dislikes[0]: | ||
start = 0 | ||
else: | ||
start = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider an edge case where dislikes
has multiple nodes at the beginning of the list that are disconnected from the graph. How might your refactor your code to address this edge case?
dogs.add(start) | ||
group_1.add(start) | ||
|
||
while len(queue): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦴 Very nice BFS implementation!
No description provided.