Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biomejs install #875

Merged
merged 6 commits into from
Jan 12, 2025
Merged

biomejs install #875

merged 6 commits into from
Jan 12, 2025

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Jan 9, 2025

Add Biome.js Configuration

This PR introduces Biome.js as a new development tool for improved code formatting and linting. Key changes include:

  • Add biome.json configuration file with customized formatting and linting rules
  • Update .editorconfig to use 2-space indentation while maintaining tab style
  • Install @biomejs/biome v1.9.4 as a dev dependency

The Biome configuration includes:

  • JavaScript/TypeScript-specific formatting rules (single quotes, trailing commas, etc.)
  • Comprehensive linting rules for complexity, correctness, style, and suspicious patterns
  • Separate rule overrides for TypeScript files
  • Carefully curated ignore patterns for specific files and directories

This change will help maintain consistent code style across the project while catching potential issues early in development.

PR Plan

  1. biomejs install <-- biomejs install #875
  2. format and lint fixes
  3. rip out old eslint and prettiers files and config

Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also remove prettier and elint and related packages

biome.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
biome.json Outdated Show resolved Hide resolved
biome.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@xlc xlc merged commit a62fab2 into AcalaNetwork:master Jan 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants