Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about private extension reverse domain naming #154

Closed
wants to merge 1 commit into from
Closed

Add section about private extension reverse domain naming #154

wants to merge 1 commit into from

Conversation

SonyDennisAdams
Copy link
Contributor

No description provided.

@SonyDennisAdams SonyDennisAdams requested a review from garyo April 1, 2024 17:15
garyo
garyo approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@garyo garyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@garyo
Copy link
Contributor

garyo commented Apr 1, 2024

Could you re-push this with DCO signoff (git commit ... -s, so it adds the Signed-Off-By line at the end of the commit message)?

@SonyDennisAdams
Copy link
Contributor Author

Could you re-push this with DCO signoff (git commit ... -s, so it adds the Signed-Off-By line at the end of the commit message)?

Apparently not; the steps I tried did not work. So I'm creating another PR which you will receive shortly. I'll close this one without merging.

@SonyDennisAdams
Copy link
Contributor Author

Closing; was missing DCO. Creating new PR fresh.

@SonyDennisAdams SonyDennisAdams deleted the doc_unique_naming branch April 1, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyo garyo garyo approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SonyDennisAdams @garyo