fix(pdf): Perform endian byteswap on correct buffer area for PSD RLE #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t buffer area for PSD RLE decoding Signed-off-by: Jesse Yurkovich <[email protected]>
|
Yeah, I would say that anything several hundred KB or more is probably better in the oiio-images repo so that it's only needed if people want to run the testsuite and not if they're just making an untested build. This is approved as-is as far as I'm concerned. Do you want me to merge now, and we can add the test later, or would you like me to wait while you add the test? |
lgritz
changed the title
lgritz
added
bug
|
I added a PR to the images repo, and if/when that goes in, I'll add a test line for it over here. |
Signed-off-by: Jesse Yurkovich <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 20, 2025
…cademySoftwareFoundation#4600) Perform the endian byteswap on the correct buffer area for PSD RLE decoding. The original code used `dst` but that pointer is modified from its original value as it progresses through decoding. Fixes AcademySoftwareFoundation#4599 --------- Signed-off-by: Jesse Yurkovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Perform the endian byteswap on the correct buffer area for PSD RLE decoding. The original code used
dstbut that pointer is modified from its original value as it progresses through decoding.Fixes #4599
Tests
It might be prudent to add a test for this. Is the repro file attached to the bug too big for this repo(842kb) or do you want them in the oiio-images repo maybe?
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.