Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fails on invalid regex #66

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

andrewjanssen
Copy link
Contributor

@andrewjanssen andrewjanssen commented Nov 8, 2024

Description

Oops, my recent PR introduced a bug where, if a user types a search string that is an invalid regex, the filter fails to be applied. Instead, the other kinds of matching like substring matching should still be performed. For example, PR 60 broke the search for (. This PR fixes that.

This PR also corrects a typo in the README related to regex search.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual testing.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@andrewjanssen andrewjanssen changed the title Fix regex exception Search fails on invalid regex Nov 8, 2024
@Abdenasser Abdenasser merged commit 01bda83 into Abdenasser:main Nov 8, 2024
1 check passed
@andrewjanssen andrewjanssen deleted the fix-regex-exception branch November 8, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants