Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/be: add swap memory #19

Closed

Conversation

laciferin2024
Copy link
Contributor

@laciferin2024 laciferin2024 commented Nov 6, 2024

@Abdenasser given that we are moving forward with #8 , lets have a swap support on backend.

@Abdenasser
Copy link
Owner

will take some time to review today, but beware to not reformat irrelevant code please.

src-tauri/src/main.rs Outdated Show resolved Hide resolved
src/lib/types/index.ts Outdated Show resolved Hide resolved
src-tauri/src/main.rs Show resolved Hide resolved
src/lib/types/index.ts Show resolved Hide resolved
@Abdenasser Abdenasser closed this Nov 8, 2024
@Abdenasser Abdenasser reopened this Nov 8, 2024
@laciferin2024 laciferin2024 force-pushed the chore/crate-update-sysinfo branch from 65cdf80 to 9ac44f9 Compare November 8, 2024 17:03
@laciferin2024
Copy link
Contributor Author

@Abdenasser can we generate types from the rust code. I think thats not a bad idea

@Abdenasser
Copy link
Owner

@Abdenasser can we generate types from the rust code. I think thats not a bad idea

not bad, but we don't have much structs to worry about

@Abdenasser Abdenasser closed this Nov 8, 2024
@laciferin2024
Copy link
Contributor Author

Hey, why did. u close it?

@Abdenasser
Copy link
Owner

Hey, why did. u close it?

@laciferin2024 oh shit, I thought this wasn't yet fixed.. will reopen, can you also add the convenient templates and test for windows too!

@Abdenasser Abdenasser reopened this Nov 9, 2024
@laciferin2024
Copy link
Contributor Author

This pr is ready

@laciferin2024
Copy link
Contributor Author

Hey, why did. u close it?

@laciferin2024 oh shit, I thought this wasn't yet fixed.. will reopen, can you also add the convenient templates and test for windows too!

Yeah i m happy too. It would be easier if u add me a colloborator now

@Abdenasser
Copy link
Owner

Hey, why did. u close it?

@laciferin2024 oh shit, I thought this wasn't yet fixed.. will reopen, can you also add the convenient templates and test for windows too!

Yeah i m happy too. It would be easier if u add me a colloborator now

the PR, needs the template updates.. and you are a collaborator (but I'm gonna keep myself the only maintainer for now)

@laciferin2024
Copy link
Contributor Author

Done the pr is ready

@Abdenasser
Copy link
Owner

Done the pr is ready

how is it done, can't see no template updated?

@laciferin2024
Copy link
Contributor Author

I guess by templates u r referring to the svelte code (UI) , while I am the early adopters of Svelte 5, we never got on a call to discuss the swap ui. So keep this pr as a reference for now.

I m quite busy with Devcon and can't handle this pr for now!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants