-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust refactor #110
Rust refactor #110
Conversation
@Pinguin2001 @andrewjanssen @nasyxx @razor950 @phillipthelen @minsusun @NoPlagiarism |
Works for me, nothing seems amiss. Node 18.13, MacOS 15.1, M1. |
thanks @andrewjanssen really appreciate your help 🙏🏻 |
Seems no problem at all building locally Node 20.14, MacOS 15.0.1 M1
It works well on dark mode, but on light mode, animation seems a little bit awkward. Maybe I should open a new issue Screen.Recording.2024-11-13.at.11.09.31.AM.mov |
thank you @minsusun yeah that effect is intentional, but feel free to tweak it a bit for light mode themes if you like |
I guess it builded, but I have some problems with Acrylic effect. Lags + incorrect size 3QXXTDUp1c.mp4 |
@NoPlagiarism you should enable glassy theme from the themes menu |
@Abdenasser I have tested it extensively and I noticed a significant improvement in startup time as well as much better structured code, great work! |
thank you, I'm also storming over a big refactor for the svelte part... will disable the effects for windows (will keep it only for macos) |
You can try |
GI04J6jRzZ.mp4 |
great, you can maybe submit a PR for that |
What about |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: