Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust refactor #110

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Rust refactor #110

merged 3 commits into from
Nov 13, 2024

Conversation

Abdenasser
Copy link
Owner

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Abdenasser
Copy link
Owner Author

@Pinguin2001 @andrewjanssen @nasyxx @razor950 @phillipthelen @minsusun @NoPlagiarism
this is a big refactor + documentation for the backend side, would really appreciate it if some of you guys can try to build this locally and see if it throws any errors (I only tested this on MacOS and it is stable, but would want to double check on other systems as well) thank you all ❤️

@andrewjanssen
Copy link
Contributor

andrewjanssen commented Nov 13, 2024

this is a big refactor + documentation for the backend side, would really appreciate it if some of you guys can try to build this locally and see if it throws any errors

Works for me, nothing seems amiss. Node 18.13, MacOS 15.1, M1.

@Abdenasser
Copy link
Owner Author

this is a big refactor + documentation for the backend side, would really appreciate it if some of you guys can try to build this locally and see if it throws any errors

Works for me, nothing seems amiss. Node 18.13, MacOS 15.1, M1.

thanks @andrewjanssen really appreciate your help 🙏🏻

@minsusun
Copy link
Contributor

minsusun commented Nov 13, 2024

this is a big refactor + documentation for the backend side, would really appreciate it if some of you guys can try to build this locally and see if it throws any errors (I only tested this on MacOS and it is stable, but would want to double check on other systems as well) thank you all ❤️

Seems no problem at all building locally

Node 20.14, MacOS 15.0.1 M1

BTW, is below glitch(?) on the title bar intended?

It works well on dark mode, but on light mode, animation seems a little bit awkward. Maybe I should open a new issue

Screen.Recording.2024-11-13.at.11.09.31.AM.mov

@Abdenasser
Copy link
Owner Author

this is a big refactor + documentation for the backend side, would really appreciate it if some of you guys can try to build this locally and see if it throws any errors (I only tested this on MacOS and it is stable, but would want to double check on other systems as well) thank you all ❤️

Seems no problem at all building locally

Node 20.14, MacOS 15.0.1 M1

BTW, is below glitch(?) on the title bar intended?

It works well on dark mode, but on light mode, animation seems a little bit awkward. Maybe I should open a new issue

Screen.Recording.2024-11-13.at.11.09.31.AM.mov

thank you @minsusun yeah that effect is intentional, but feel free to tweak it a bit for light mode themes if you like

@Abdenasser Abdenasser merged commit dea6d2a into main Nov 13, 2024
2 checks passed
@NoPlagiarism
Copy link
Contributor

I guess it builded, but I have some problems with Acrylic effect. Lags + incorrect size

3QXXTDUp1c.mp4

@Abdenasser
Copy link
Owner Author

Abdenasser commented Nov 13, 2024

I guess it builded, but I have some problems with Acrylic effect. Lags + incorrect size

3QXXTDUp1c.mp4

@NoPlagiarism you should enable glassy theme from the themes menu

@NoPlagiarism
Copy link
Contributor

you should enable glassy theme from the themes menu

image

It works, but Acrylic effect is still very-very laggy for me

It would be nice to disable Acrylic (of course, it should exclude Glassy from themes)

@NoPlagiarism
Copy link
Contributor

it should exclude Glassy from themes

Just FYI, this is how Glassy looks on Windows 10 22H2 without Acrylic effect (and w/o any other modifications except removing it)

image

@Pinguin2001
Copy link
Contributor

@Abdenasser I have tested it extensively and I noticed a significant improvement in startup time as well as much better structured code, great work!

@Abdenasser
Copy link
Owner Author

@Abdenasser I have tested it extensively and I noticed a significant improvement in startup time as well as much better structured code, great work!

thank you, I'm also storming over a big refactor for the svelte part... will disable the effects for windows (will keep it only for macos)

@NoPlagiarism
Copy link
Contributor

NoPlagiarism commented Nov 13, 2024

will disable the effects for windows

You can try apply_blur for Windows 10 and apply_mica for Windows 11 on loading Glassy themes + clear_blur / clear_mica after switching off Glassy theme

@NoPlagiarism
Copy link
Contributor

apply_acrylic vs apply_blur

GI04J6jRzZ.mp4

@Abdenasser
Copy link
Owner Author

apply_acrylic vs apply_blur

GI04J6jRzZ.mp4

great, you can maybe submit a PR for that

@NoPlagiarism
Copy link
Contributor

What about apply_mica for Windows 11? I'm not sure about me testing it, since I need VM to do it

@Abdenasser Abdenasser deleted the rust-refactor branch November 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants