Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code, resolve Internal Server Error issues #73

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Refactor code, resolve Internal Server Error issues #73

merged 7 commits into from
Apr 9, 2024

Conversation

Lopkop
Copy link
Contributor

@Lopkop Lopkop commented Apr 7, 2024

  1. if you pass random string in application_id in apis you will get 500 server error, now you get 422 Unprocessable Entity.
  2. Non-router function in router module were put into services.py file in dependencies module for convenience.

@fisher60 fisher60 requested a review from GDWR April 8, 2024 19:35
GDWR
GDWR approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@GDWR GDWR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just comments on styling. Thanks for the contribution!

abandonauth/routers/index.py Outdated Show resolved Hide resolved
abandonauth/routers/ui.py Outdated Show resolved Hide resolved
@GDWR GDWR merged commit 30897a1 into AbandonTech:main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GDWR GDWR GDWR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lopkop @GDWR