Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with HTTP status codes /ui/login and type checks #71

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Lopkop
Copy link
Contributor

@Lopkop Lopkop commented Apr 4, 2024

  1. GET : https://.../ui/login?application_id=fake&callback_uri=/ui
    bad application_id (not uuid) now gives 422 Unprocessable Entity, instead of 500.

  2. If you will pass application_id that is existing in db, application will return 404 status code.

closes #68

UUID cannot be serialized, so we need to convert it to a string.
@Lopkop Lopkop changed the title Resolve issue with HTTP status codes /ui/login Resolve issue with HTTP status codes /ui/login and type checks Apr 4, 2024
@fisher60 fisher60 requested a review from GDWR April 4, 2024 15:03
Copy link
Member

@fisher60 fisher60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@fisher60 fisher60 merged commit 4d03dcf into AbandonTech:main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing invalid application_id format results in 500 error instead of 422 at /ui/login
2 participants