Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 update. Other minor changes. #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jswedenburg
Copy link

Hi, I thought your project looked interesting so I decided to help out. I updated to Swift 3. Once I did that there were some errors with NSDictionary and NSArray types. So I changed those to [String: Any] and [[String: Any]] respectively. Also after the Swift 3 update, the forecastURL was not working and recieving optional values from the userLatitude and userLongitude. I fixed that issue. I also changed the NSError type to Error in URLSessionDownloadTask.

Also, I noticed a bug (see screenshot) where the optional values of locality, postalCode, adminArea, and country were never actually getting unwrapped. They were remaining as optionals and displaying as optionals on screen. I fixed this as well.

This is a fun project and I hope I can keep contributing in the future. One more thing, is this available on the App Store in the US? When I followed the link, I was told it was not available in the US Store.

img_4056

Updated dictionary types to [String: Any] where needed. Also updated Array types to [[String: Any]] where needed.
After Swift 3 Update, the forecastURL was recieving optional values from the userLatitude and userLongitude. Also changed the NSError type to Error in download task.
The optional values of locality, postalCode, adminArea, and country were never actually getting unwrapped. They were remaining as optionals and displaying as optionals on screen.
@Buxfiz
Copy link

Buxfiz commented Mar 19, 2017

Brilliant work jswedenburg! Thank you for these updates. I aslo think this a funproject and was having problems converting to Swift3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants