Add ListCommand closes #7 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnivedit
force-pushed
the
dev/listcommand
branch
from
e1faf77 to
827bed2
Compare
yijiano
approved these changes
Oct 12, 2024
| public class ListCommand extends Command{ | ||
| public ListCommand() {} | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Good work here, clean and concise code. Maybe you can add JavaDocs next time.
|
|
||
| //Compare output | ||
| String output = outputStream.toString(); | ||
| assertEquals(output, expectedOutput); |
There was a problem hiding this comment.
Good work on the JUnit test implementation for ListItems!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ListCommand class with empty constructor, execute method overrides baseclass
Add JUnit tests for empty list and sample test cases