Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser check valid argument and description #273

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Parser check valid argument and description #273

merged 2 commits into from
Nov 9, 2024

Conversation

kestryix
Copy link

@kestryix kestryix commented Nov 9, 2024

No description provided.

This was linked to issues Nov 9, 2024
[PE-D][Tester D] Does not catch missing arguments from list command when both from and to flags are not specified. #251
Closed
[PE-D][Tester D] Does not catch missing argument for /from flag for list command #249
Closed
[PE-D][Tester B] [UG] Edit Transaction Description Parameter stated as "shouldn't be blank" but possible to execute edit with blank description #238
Closed
[PE-D][Tester D] Does not catch invalid /des flag for edit command #239
Closed
@kestryix kestryix removed a link to an issue Nov 9, 2024
[PE-D][Tester D] Does not catch invalid /des flag for edit command #239
Closed
This was linked to issues Nov 9, 2024
[PE-D][Tester D] Does not catch invalid /des flag for edit command #239
Closed
[PE-D][Tester C] Editing of entries does not handle wrong user input #241
Closed
limkongkiat
limkongkiat approved these changes Nov 9, 2024
View reviewed changes
Copy link

@limkongkiat limkongkiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps you could also try to extract your code into smaller methods (e.g. maybe if-blocks written to throw errors can be extracted as void methods)

@kestryix kestryix merged commit 6105a7e into AY2425S1-CS2113-W14-3:master Nov 9, 2024
3 checks passed
This was linked to issues Nov 11, 2024
[PE-D][Tester D] Does not catch missing description argument for edit command #242
Closed
[PE-D][Tester C] Exception gives user the wrong hint when encountering invalid input #223
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limkongkiat limkongkiat limkongkiat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kestryix @limkongkiat