Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of sort command in DG #188

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

siqirua
Copy link
Collaborator

@siqirua siqirua commented Nov 13, 2023

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #188 (9d5c0bb) into master (7d612ca) will increase coverage by 11.64%.
Report is 40 commits behind head on master.
The diff coverage is 53.57%.

@@              Coverage Diff              @@
##             master     #188       +/-   ##
=============================================
+ Coverage     57.31%   68.96%   +11.64%     
- Complexity      718      863      +145     
=============================================
  Files           126      126               
  Lines          3238     3293       +55     
  Branches        375      385       +10     
=============================================
+ Hits           1856     2271      +415     
+ Misses         1203      824      -379     
- Partials        179      198       +19     
Files Coverage Δ
...edu/modulight/logic/commands/AutoGradeCommand.java 96.72% <100.00%> (+96.72%) ⬆️
src/main/java/seedu/modulight/model/UserPrefs.java 77.77% <100.00%> (+5.55%) ⬆️
...modulight/storage/JsonSerializableStudentBook.java 100.00% <ø> (+100.00%) ⬆️
...in/java/seedu/modulight/model/student/Student.java 97.18% <50.00%> (-1.39%) ⬇️
...edu/modulight/model/studentscore/StudentScore.java 82.81% <0.00%> (+2.81%) ⬆️
...ulight/model/studentscore/ScoreMatchPredicate.java 92.85% <0.00%> (-4.16%) ⬇️
.../modulight/storage/JsonAdaptedGradedComponent.java 89.18% <50.00%> (+89.18%) ⬆️
...edu/modulight/storage/JsonAdaptedStudentScore.java 56.89% <23.80%> (+56.89%) ⬆️

... and 19 files with indirect coverage changes

@seraphimstreets seraphimstreets merged commit 88f7c26 into AY2324S1-CS2103T-W08-2:master Nov 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants