Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Quality #178

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

siqirua
Copy link
Collaborator

@siqirua siqirua commented Nov 13, 2023

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #178 (7d612ca) into master (829bbaa) will increase coverage by 0.11%.
Report is 6 commits behind head on master.
The diff coverage is 59.37%.

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     57.20%   57.31%   +0.11%     
- Complexity      710      718       +8     
============================================
  Files           126      126              
  Lines          3246     3238       -8     
  Branches        378      375       -3     
============================================
- Hits           1857     1856       -1     
+ Misses         1209     1203       -6     
+ Partials        180      179       -1     
Files Coverage Δ
...ight/logic/commands/DeleteStudentScoreCommand.java 0.00% <ø> (ø)
...u/modulight/logic/commands/FindStudentCommand.java 100.00% <100.00%> (ø)
...seedu/modulight/logic/commands/ListAllCommand.java 0.00% <ø> (ø)
...u/modulight/logic/commands/SortStudentCommand.java 68.18% <ø> (ø)
...ulight/logic/commands/SortStudentScoreCommand.java 70.00% <ø> (ø)
.../logic/parser/AddGradedComponentCommandParser.java 0.00% <ø> (ø)
...odulight/logic/parser/AddStudentCommandParser.java 95.23% <100.00%> (-0.22%) ⬇️
...logic/parser/EditGradedComponentCommandParser.java 0.00% <ø> (ø)
...dulight/logic/parser/EditStudentCommandParser.java 85.29% <ø> (ø)
...ht/logic/parser/EditStudentScoreCommandParser.java 80.00% <ø> (ø)
... and 9 more

@seraphimstreets seraphimstreets merged commit c343734 into AY2324S1-CS2103T-W08-2:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants