Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS Routetable #27

Merged
merged 9 commits into from
Jul 23, 2024
Merged

KMS Routetable #27

merged 9 commits into from
Jul 23, 2024

Conversation

jwaltireland
Copy link
Collaborator

Overview/Summary

added support for KMS azure services for windows activation by adding NSG and routetable

This PR fixes/adds/changes/removes

  1. if vnet is existing, create NSG and Route table and associate with the subnet
  2. added param for storage OU for domjoin
  3. updated application group display name
  4. updated github urls to point to the arpah repo

@petersonjdNIH petersonjdNIH changed the title Kms routetable KMS Routetable Jul 23, 2024
@petersonjdNIH petersonjdNIH self-requested a review July 23, 2024 02:57
@petersonjdNIH petersonjdNIH merged commit c59acf3 into main Jul 23, 2024
1 check passed
@petersonjdNIH petersonjdNIH deleted the kms-routetable branch July 23, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersonjdNIH petersonjdNIH petersonjdNIH approved these changes

Assignees

@petersonjdNIH petersonjdNIH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwaltireland @petersonjdNIH