-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FMV] Unify sha1, sha2. #347
Conversation
According to ArmARM: SHA2, bits [15:12] 0b0000 No SHA2 instructions implemented. FEAT_SHA256 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000. SHA1, bits [11:8] 0b0000 No SHA1 instructions implemented. FEAT_SHA1 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000. To my understanding this means you can't have one without the other.
LGTM. |
There is no rule to mandate https://docs.kernel.org/arch/arm64/elf_hwcaps.html both kernel reports them separately. |
I came to the same conclusion when reading "If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000". But this line "If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000" makes me think that you can't have FEAT_SHA1 without FEAT_SHA256.
The kernel also reports SM3 and SM4 separately but they are lumped in FMV. So as SHA512 and SHA3. Why is that? |
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (ARM-software/acle#347) therefore I am adjusting the runtime tests for it.
@@ -402,6 +402,7 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin | |||
a misplaced anchor. | |||
* Added `__FUNCTION_MULTI_VERSIONING_SUPPORT_LEVEL` to indicate the support | |||
level of the [Function Multi Versioning](#function-multi-versioning). | |||
* Unified Function Multi Versioning features sha1, sha2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHA-1 and SHA-2.
(I missed the capitalization on a previous review - please make all mentions of SHA consistent. It's an acronym so must be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is referencing the toolchain feature string, not the hash functions themselves, so lowercase is correct. If anything needs to change, it would be to put in quotes or format it as code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalisation needed.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
Sha1 has been unified with sha2 in the ACLE spec (see ARM-software/acle#347) so I am changing the compiler to adhere to it.
According to ArmARM:
SHA2, bits [15:12]
0b0000 No SHA2 instructions implemented.
FEAT_SHA256 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA1 is 0b0000, this field must have the value 0b0000.
SHA1, bits [11:8]
0b0000 No SHA1 instructions implemented.
FEAT_SHA1 implements the functionality identified by the value 0b0001. If the value of ID_AA64ISAR0_EL1.SHA2 is 0b0000, this field must have the value 0b0000.
To my understanding this means you can't have one without the other.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
X
those which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightText
lines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019
, and usecommas to separate gaps, as in
2018-2020, 2022
).Copyright
section of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversion
is set totrue
in the YAML headerof the sources of the specifications I have modified.
in the README page of the project.