Use keywords for SME attributes #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandifo-arm
force-pushed
the
sme-keywords
branch
from
8982ae7
to
52765fc
Compare
sdesmalen-arm
added a commit
to llvm/llvm-project
that referenced
this pull request
Aug 8, 2023
This patch adds all the language-level function keywords defined in: ARM-software/acle#188 (merged) ARM-software/acle#261 (update after D148700 landed) The keywords are used to control PSTATE.ZA and PSTATE.SM, which are respectively used for enabling the use of the ZA matrix array and Streaming mode. This information needs to be available on call sites, since the use of ZA or streaming mode may have to be enabled or disabled around the call-site (depending on the IR attributes set on the caller and the callee). For calls to functions from a function pointer, there is no IR declaration available, so the IR attributes must be added explicitly to the call-site. With the exception of '__arm_locally_streaming' and '__arm_new_za' the information is part of the function's interface, not just the function definition, and thus needs to be propagated through the FunctionProtoType::ExtProtoInfo. This patch adds the defintions of these keywords, as well as codegen and semantic analysis to ensure conversions between function pointers are valid and that no conflicting keywords are set. For example, '__arm_streaming' and '__arm_streaming_compatible' are mutually exclusive. Differential Revision: https://reviews.llvm.org/D127762
rsandifo-arm
force-pushed
the
sme-keywords
branch
2 times, most recently
from
f7a1285
to
b9eda28
Compare
A patch series recently went into Clang to support a kind of keyword attribute that can appear wherever a standard attribute can appear, and that appertains to whatever a standard attribute appertains to: https://reviews.llvm.org/D148700 This patch changes the syntax used for SME to match this style, rather than using GNU attributes. That avoid the previous situation in which older compilers would ignore (or just warn about) SME attributes, and so would generate wrong code.
rsandifo-arm
force-pushed
the
sme-keywords
branch
from
b9eda28
to
74307a2
Compare
sdesmalen-arm
approved these changes
Aug 17, 2023
CarolineConcatto
pushed a commit
to CarolineConcatto/acle
that referenced
this pull request
Dec 6, 2023
A patch series recently went into Clang to support a kind of keyword attribute that can appear wherever a standard attribute can appear, and that appertains to whatever a standard attribute appertains to: https://reviews.llvm.org/D148700 This patch changes the syntax used for SME to match this style, rather than using GNU attributes. That avoid the previous situation in which older compilers would ignore (or just warn about) SME attributes, and so would generate wrong code.
| @@ -351,6 +351,14 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin | |||
| * Added a requirement on [`arm_new_za`](#arm_new_za) to set the initial | |||
| contents of ZA to zero. | |||
|
|
|||
| #### Changes for next release | |||
There was a problem hiding this comment.
Do you mean Changes in this release?
There was a problem hiding this comment.
I think the convention is to use “Changes in the next release” for changes that been made to the document since the last release (in other words, for changes that haven't yet been released, but that are queued up for the next/upcoming release). The “next release” part is then replaced with a release version just before the release.
There was a problem hiding this comment.
That's correct. That piece of text will be replaced in the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
Xthose which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.