-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable targetting v8-A Aarch-32 #484
Conversation
cmake/multilib.yaml.in
Outdated
@@ -148,9 +148,18 @@ Mappings: | |||
# of each other, in the obvious way, but we don't have any libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this comment to match.
cmake/multilib.yaml.in
Outdated
@@ -148,9 +148,18 @@ Mappings: | |||
# of each other, in the obvious way, but we don't have any libraries | |||
# for those at present, so there's no need to generate all their | |||
# flags.) | |||
- Match: --target=armv(8\.[1-9]|9|9\.[1-9])a-unknown-none-eabi | |||
- Match: --target=armv(8|8\.[1-9]|9|9\.[1-9])a-unknown-none-eabi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use (arm|thumb)
in the triple (see armv7ve
above for example) to halve the number of Match
blocks here, because the ISA doesn't matter for library selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Enable targetting v8-A Aarch-32 * fixup! Enable targetting v8-A Aarch-32
* Enable targetting v8-A Aarch-32 * fixup! Enable targetting v8-A Aarch-32
No description provided.