Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/app] Live Activity 추가 작업 및 리소스 프레임워크 분리 #232

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
df2112d
test cache'
hyeonghwan May 8, 2024
63d528f
Merge branch 'dev' of https://github.com/APPSCHOOL3-iOS/final-pickle …
hyeonghwan May 8, 2024
a684ebc
refactor: Timer 증가, 감소 변경 조건문 리팩토링
hyeonghwan May 14, 2024
8ec3d31
refactor: CircleTimerView Component 분리
hyeonghwan May 14, 2024
4b037d9
refactor: Timer View 재 렌더링 방지 Equtable 추가 , 비지니스 로직 컴포넌트에서 제거
hyeonghwan May 14, 2024
9512145
fix: Final 추가
hyeonghwan May 14, 2024
2e5ce85
refactor: View 분리, 변수명 , 함수 접근제어 변경
hyeonghwan May 14, 2024
8dc0552
refactor: 라인 정리, 컴포넌트 분리 작업에서 TimerView에 비지니스 로직 추가
hyeonghwan May 14, 2024
063a689
style: 변수명 변경 및 정리
hyeonghwan May 14, 2024
b8f12ea
refactor: TimerView에서 컴포넌트 분리로 View component 생성
hyeonghwan May 14, 2024
5d5978c
Feat: Live Activity Extension 추가, LiveActivity CRUD class 생성
hyeonghwan May 14, 2024
50e02c0
refactor: Widget Extension 과 share 하기위해서 AppStorage To App Group Migr…
hyeonghwan May 14, 2024
8758c1e
Feat: 모듈간 App Resource 공유를 위한 Resource FrameWork 추가, 리소스(폰트 컬러 Ext) 이동
hyeonghwan May 14, 2024
99fd7da
Feat: 모듈 import, 주석 라인 정리
hyeonghwan May 14, 2024
ca8dfd2
Refactor: 변수 이름 변경 및 폰트 Register 코드 추가
hyeonghwan May 14, 2024
e52acbe
Refactor: 접근제어자 Public 으로 변경
hyeonghwan May 14, 2024
cab9f86
Refactor: 변수명 변경
hyeonghwan May 14, 2024
db94783
Feat: Home 화면 Lottie 뷰 추가
hyeonghwan May 14, 2024
cfad71a
build: Test Scheme 누락 으로 인한 추가
hyeonghwan May 15, 2024
d550a43
Build: Test Scheme 수정, Test Plan, Target 버젼 수정
hyeonghwan May 15, 2024
e8ec806
Update from project to workspace
hyeonghwan May 15, 2024
2858e90
Update test_dev.yml
hyeonghwan May 15, 2024
4668723
Update test_dev.yml
hyeonghwan May 15, 2024
3414292
fix: Realm Migration On
hyeonghwan May 15, 2024
cca0285
Update test_dev.yml
hyeonghwan May 15, 2024
b67e563
Update test_dev.yml
hyeonghwan May 15, 2024
81b7101
build: Version 1.1.0
hyeonghwan May 15, 2024
d39acad
keyPath: KeyPath thorw 제거, 실패시 self 반환
hyeonghwan May 15, 2024
8fe8d97
build/test: GitHub Action Fail 원인 수정 , syntax error -> KeyPath commit…
hyeonghwan May 15, 2024
20676d1
Merge branch 'refactor/app' of https://github.com/APPSCHOOL3-iOS/fina…
hyeonghwan May 15, 2024
5bf077c
Update test_dev.yml
hyeonghwan May 15, 2024
c5ed0af
fix: Live Activity 뷰 정렬, 관련함수 추가
hyeonghwan May 15, 2024
622f482
Merge branch 'refactor/app' of https://github.com/APPSCHOOL3-iOS/fina…
hyeonghwan May 15, 2024
9d30c1e
fix: Test 오류 수정
hyeonghwan May 15, 2024
2d1a1e6
gitignore Text File add
hyeonghwan May 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Run Test

env:
PROJECT: 'Pickle'
PROJECT: 'PickleApp'

on:
# dev 브랜치에 pull request 이벤트가 일어났을때 해당 workflow 를 trigger
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
if: github.event_name == 'pull_request'
run: |
xcodebuild test \
-project Pickle/Pickle.xcodeproj \
-workspace ${{env.PROJECT}}.xcworkspace \
-scheme Pickle \
-destination 'platform=iOS Simulator,name=iPhone 15 Pro,OS=17.0.1'

Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,4 @@ iOSInjectionProject/

# 프로젝트의 모든 경로에서 GoogleService-Info.plist 파일을 포함하지 않도록 함
**/GoogleService-Info.plist

**/keypath.txt
2 changes: 2 additions & 0 deletions Pickle/Pickle-release-info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>Supports Live Activities</key>
<string>YES</string>
<key>BGTaskSchedulerPermittedIdentifiers</key>
<array>
<string>com.ddudios.realpizza.refresh_badge</string>
Expand Down
508 changes: 408 additions & 100 deletions Pickle/Pickle.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
{
"originHash" : "182db11c87d1734fe53a6366b674339f70901a93290bd85def29b63e25e34c43",
"originHash" : "3430a87206e1a7b3791f8b0cd89d99b1f4831ce93ae3bdf5f3fc4d62e8d0c589",
"pins" : [
{
"identity" : "lottie-spm",
"kind" : "remoteSourceControl",
"location" : "https://github.com/airbnb/lottie-spm.git",
"state" : {
"revision" : "1d29eccc24cc8b75bff9f6804155112c0ffc9605",
"version" : "4.4.3"
}
},
{
"identity" : "realm-core",
"kind" : "remoteSourceControl",
Expand Down
35 changes: 26 additions & 9 deletions Pickle/Pickle.xcodeproj/xcshareddata/xcschemes/Pickle.xcscheme
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
buildImplicitDependencies = "YES"
buildArchitectures = "Automatic">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
Expand All @@ -26,17 +27,33 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
shouldAutocreateTestPlan = "YES">
shouldUseLaunchSchemeArgsEnv = "YES">
<TestPlans>
<TestPlanReference
reference = "container:PickleTests/Pickle.xctestplan"
default = "YES">
</TestPlanReference>
</TestPlans>
<Testables>
<TestableReference
skipped = "NO"
skipped = "YES"
parallelizable = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "96AA8C8F2BEE747C0075CFE8"
BuildableName = "CommonTests.xctest"
BlueprintName = "CommonTests"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</TestableReference>
<TestableReference
skipped = "YES"
parallelizable = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "965C9B9E2ADAB2380015ABBE"
BuildableName = "PickleTests.xctest"
BlueprintName = "PickleTests"
BlueprintIdentifier = "96AA8CB22BEE74FA0075CFE8"
BuildableName = "PickleCommonTests.xctest"
BlueprintName = "PickleCommonTests"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</TestableReference>
Expand Down Expand Up @@ -64,7 +81,7 @@
</BuildableProductRunnable>
</LaunchAction>
<ProfileAction
buildConfiguration = "Debug"
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
Expand All @@ -84,7 +101,7 @@
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Debug"
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1530"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES"
buildArchitectures = "Automatic">
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
shouldAutocreateTestPlan = "YES">
<Testables>
<TestableReference
skipped = "NO"
parallelizable = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "965C9B9E2ADAB2380015ABBE"
BuildableName = "PickleTests.xctest"
BlueprintName = "PickleTests"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1530"
wasCreatedForAppExtension = "YES"
version = "2.2">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES"
buildArchitectures = "Automatic">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<AutocreatedTestPlanReference>
</AutocreatedTestPlanReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "969B88F82BEB9F0000538D12"
BuildableName = "TaskLiveActivityExtension.appex"
BlueprintName = "TaskLiveActivityExtension"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2137D5742AC1459C00AFE225"
BuildableName = "Pickle.app"
BlueprintName = "Pickle"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
shouldAutocreateTestPlan = "YES">
<Testables>
<TestableReference
skipped = "NO"
parallelizable = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "96AA8C8F2BEE747C0075CFE8"
BuildableName = "CommonTests.xctest"
BlueprintName = "CommonTests"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</TestableReference>
<TestableReference
skipped = "NO"
parallelizable = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "96AA8CB22BEE74FA0075CFE8"
BuildableName = "PickleCommonTests.xctest"
BlueprintName = "PickleCommonTests"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = ""
selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn"
launchStyle = "0"
askForAppToLaunch = "Yes"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES"
launchAutomaticallySubstyle = "2">
<RemoteRunnable
runnableDebuggingMode = "2"
BundleIdentifier = "com.apple.springboard">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "969B88F82BEB9F0000538D12"
BuildableName = "TaskLiveActivityExtension.appex"
BlueprintName = "TaskLiveActivityExtension"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</RemoteRunnable>
<EnvironmentVariables>
<EnvironmentVariable
key = "_XCWidgetKind"
value = ""
isEnabled = "YES">
</EnvironmentVariable>
<EnvironmentVariable
key = "_XCWidgetDefaultView"
value = "timeline"
isEnabled = "YES">
</EnvironmentVariable>
<EnvironmentVariable
key = "_XCWidgetFamily"
value = "systemMedium"
isEnabled = "YES">
</EnvironmentVariable>
</EnvironmentVariables>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES"
askForAppToLaunch = "Yes"
launchAutomaticallySubstyle = "2">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2137D5742AC1459C00AFE225"
BuildableName = "Pickle.app"
BlueprintName = "Pickle"
ReferencedContainer = "container:Pickle.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
2 changes: 1 addition & 1 deletion Pickle/Pickle/Data/Service/RealmMigrator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class RealmMigrator {
schemaVersion: 3, migrationBlock: { migration, oldSchemaVersion in
if oldSchemaVersion < 2 { migrationFromV1ToV2(migration: migration) }
if oldSchemaVersion < 3 { migrationFromV2ToV3(migration: migration) }
}, deleteRealmIfMigrationNeeded: true)
}, deleteRealmIfMigrationNeeded: false)

func migrationFromV1ToV2(migration: Migration) {
migration.enumerateObjects(ofType: UserObject.className()) { oldObject, newObject in
Expand Down
1 change: 1 addition & 0 deletions Pickle/Pickle/Global/Common/Alert/PizzaAlert.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//

import SwiftUI
import PickleCommon

extension View {
func showPizzaAlert(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//

import SwiftUI
import PickleCommon

struct PrimaryButtonModifier: ViewModifier {

Expand Down
3 changes: 3 additions & 0 deletions Pickle/Pickle/Global/Common/Picker/PickerView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//

import SwiftUI
import PickleCommon

struct PickerView: View {

Expand All @@ -26,10 +27,12 @@ struct PickerView: View {
.font(.pizzaBody)
.foregroundColor(.pickle)
}

Spacer()

Text("\(title) 설정")
.font(.nanumEbTitle)

Spacer()

Button {
Expand Down
3 changes: 3 additions & 0 deletions Pickle/Pickle/Global/Dependency/Injected/Container.swift
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ struct Container {
}
Log.error("fattalError singleton Occur")
assert(false, "fattalError singleton Occur")

case .newSingleton:
let service = factories[serviceName]?() as? Dependency
if let service = service {
Expand All @@ -53,13 +54,15 @@ struct Container {
}
Log.error("fattalError singleton Occur")
assert(false, "fattalError singleton Occur")

case .new, .automatic:
if let dependency = factories[serviceName]?() as? Dependency {
return dependency
}
Log.error("fattalError singleton Occur")
assert(false, "fattalError singleton Occur")
}

return nil
}
}
Loading
Loading