Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unauthenticated data #222

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Allow unauthenticated data #222

merged 4 commits into from
Sep 3, 2024

Conversation

commial
Copy link
Contributor

@commial commial commented Sep 3, 2024

Fix #167

Credits @extiop

This PR:

  • change the default behavior of FailSafeReader to return only authenticated data
  • add a possibility to have the old behavior (returning unauthenticated data)
  • add a --allow-unauthenticated-data flag to mlar repair to enable this flag (this is not recommended)

@commial commial added mlar Concerns the mlar utility tests Relative to the testing capabilities refactoring Code refactoring labels Sep 3, 2024
@commial commial merged commit eeac3c3 into master Sep 3, 2024
21 of 33 checks passed
@commial commial deleted the allow-unauthenticated-data branch September 3, 2024 15:13
@extiop extiop mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mlar Concerns the mlar utility refactoring Code refactoring tests Relative to the testing capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider a --allow-unauthenticated-data flags for repair
1 participant
@commial