-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "mlakey-parser" for ASN.1 MLA key import & export #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commial
added
mlar
Concerns the mlar utility
tests
Relative to the testing capabilities
refactoring
Code refactoring
labels
Jul 30, 2024
commial
force-pushed
the
mlakey-parser
branch
2 times, most recently
from
August 2, 2024 09:32
34ea974
to
27c0c52
Compare
The last C bindings test is failing due to the use of |
Open
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mlar
Concerns the mlar utility
refactoring
Code refactoring
tests
Relative to the testing capabilities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #195
This PR introduces
mlakey-parser
in replacement of the cratecurve25519-parser
.Indeed, the new hybrid key uses more than a curve 25519 key.
This PR updates the others crates to use the new MLA key format, and add some test key for tests.
A few notes:
curve25519-parser
which were instaciating a remote crate structure (fromx25519-dalek
),mlakey-parser
imports the cratemla
to have a structure representing a public and a private keyml-kem
doesn't not providesZeroization
for its decapsulating key. As a result, theZeroization
of amla
key is only partialmlar
seed's derivation scheme #214The format used to serialize the private key in ASN.1 is the following:
Or, as a tree:
The two main sequence can be inverted: starting from the MLKEM, then the X/Ed25519 key.