Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Format-v2] Generate cryptographic materials *inside* MLA, instead of using the user configuration #210

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

commial
Copy link
Contributor

@commial commial commented Jul 25, 2024

For now, the sensitive cryptographic materials are created when the API user is creating the ArchiveWriterConfig.

For the Encrypt layer, this configuration is used to add recipient.
In order to:

As a result, this PR introduce the following workflow:

                      `ArchiveWriterConfig`  <--> User, add recipients, set the compression level, etc.
                              |
                              v
                      -------------- MLA ---
                              |
                       .to_persistent()
                           /       \
 MLA specifics <= InternalConfig  PersistentConfig => to be stored in the header,
                                                      for futur reloaded by the Reader

A few refactoring are also made, such as removing from the public API to_persistent and enforcing the CSPRNG used to implement the trait CryptoRngCore (it was already, but now it is check at compile time, ensuring some robustness to dependency change)

@commial commial added enhancement New feature or request refactoring Code refactoring labels Jul 25, 2024
@commial
Copy link
Contributor Author

commial commented Jul 26, 2024

Failing tests are caused by an update to Py-bindings (unrelated to this PR) and the "long" test CI enabling the check_archive_v1 test, which is expected to fail

@commial commial merged commit 5168e4a into formatv2 Jul 26, 2024
19 of 33 checks passed
@commial commial deleted the internal_config branch July 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant