Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve colours combination,overlapping of text and hover effect css in footer section issue #1259 #1348

Closed
wants to merge 5 commits into from
Closed

improve colours combination,overlapping of text and hover effect css in footer section issue #1259 #1348

wants to merge 5 commits into from

Conversation

rahulbamnuya
Copy link

@rahulbamnuya rahulbamnuya commented Oct 23, 2024 •
edited
Loading

Pull Request Checklist

Issue : #1259
Before :

WordWise.and.8.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-24.04-56-42.mp4

After :

WordWise.Mozilla.Firefox.2024-10-24.04-43-16.mp4
WordWise.Mozilla.Firefox.2024-10-24.04-43-56.mp4
  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:04am

@ANSHIKA-26
Copy link
Owner

twitter icon not visible in dark mode

@ANSHIKA-26
Copy link
Owner

add a line to separate the footer section

@ANSHIKA-26 ANSHIKA-26 mentioned this pull request Oct 24, 2024
Closed
@rahulbamnuya
Copy link
Author

rahulbamnuya commented Oct 24, 2024 •
edited
Loading

@ANSHIKA-26 can you review please
Screenshot (283)
Screenshot (284)
can you please increase level for this will take lot of my time i have correct all transition effect ,color combination, twitter icons bugs and give new css with animination footer heading part in heading

@ANSHIKA-26
Copy link
Owner

resolve conflicts

@rahulbamnuya
Copy link
Author

@ANSHIKA-26 I will resolve it

@hiteashgupta1
Copy link
Collaborator

You have added copyright line 2times change it

hiteashgupta1
hiteashgupta1 requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@hiteashgupta1 hiteashgupta1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do remove one Copyright line

hiteashgupta1
hiteashgupta1 requested changes Oct 24, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
rahulbamnuya
rahulbamnuya commented Oct 24, 2024
View reviewed changes
Copy link
Author

@rahulbamnuya rahulbamnuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remove copyright duplication

@hiteashgupta1
Copy link
Collaborator

Resolve conflicts

@ANSHIKA-26
Copy link
Owner

closing PR due to no response

@ANSHIKA-26 ANSHIKA-26 closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiteashgupta1 hiteashgupta1 hiteashgupta1 requested changes

Assignees
No one assigned
Labels
gssoc-ext hacktoberfest-accepted level 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulbamnuya @ANSHIKA-26 @hiteashgupta1