Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve format consistency with lint plugins #863

Open
wants to merge 16 commits into
base: release/v4.1.0
Choose a base branch
from
+1,346 −1,301
Open

Improve format consistency with lint plugins #863

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
742d89f
chore: add pre-commit to address issue #818
Nov 15, 2024
ae104f2
fix: correct constants import and usage
Nov 15, 2024
cdb8986
chore: add recommended options for max applicants filter
Nov 15, 2024
707cd5e
chore: update isort configuration for improved compatibilty with ruff…
Nov 15, 2024
a77d5d4
chore: fix all pre-config issues so nobody else has to
Nov 15, 2024
fd8c5e4
chore: update formatting
Nov 15, 2024
0d9d5b4
chore: remove unnecessary hook
Nov 15, 2024
73c1539
chore: remove unnecessary variables
Nov 16, 2024
be3476e
chore: suppress E402
Nov 16, 2024
c251aaf
fix: correct relative import statements
Nov 16, 2024
7886b77
chore: remove isort config per https://github.com/AIHawk-FOSS/Auto_Jo…
Nov 16, 2024
d46ace4
chore: remove trailing comment per https://github.com/AIHawk-FOSS/Aut…
Nov 16, 2024
1209648
chore: add missing dependency versions (and remove redundant entry) p…
Nov 16, 2024
9b98236
chore: add ruff rule E402 per https://github.com/AIHawk-FOSS/Auto_Job…
Nov 17, 2024
a6f3a11
chore: remove path hack per https://github.com/AIHawk-FOSS/Auto_Jobs_…
Nov 17, 2024
7b3b723
fix: prevent AttributeError thrown for users not using openai.
Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
# Suppress stderr only during specific operations
original_stderr = sys.stderr

# Add the src directory to the Python path
sys.path.append(str(Path(__file__).resolve().parent / "src"))


class ConfigError(Exception):
pass
Expand Down
4 changes: 3 additions & 1 deletion src/ai_hawk/linkedIn_easy_applier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.support.ui import Select, WebDriverWait

import config
import constants
from src.ai_hawk.llm.llm_manager import GPTAnswerer
from src.job import Job
from src.job_application import JobApplication
Expand Down Expand Up @@ -483,7 +485,7 @@ def _handle_upload_fields(self, element: WebElement, job_context: JobContext) ->
job_context.job.resume_path = str(self.resume_path.resolve())
job_context.job_application.resume_path = str(self.resume_path.resolve())
logger.debug(f"Resume uploaded from path: {self.resume_path.resolve()}")
else:
elif config.LLM_MODEL_TYPE is constants.OPENAI:
logger.debug("Resume path not found or invalid, generating new resume")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it should brake execution not debug logs. throw error which can close program

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surapuramakhil That would cause the program to exit for anyone not using OpenAI.

It was not my goal to change any functionality. I simply wanted to update the conditional checks to match the current dependency logic. I kept seeing feder's old resume generator throw an error because I'm using Ollama. It was annoying and discracting, so this fix helps get rid of that error message for those who don't need to see it.

I can add an else statement again with an info log saying that no resume is selected and resume generation is unavailable for the current llm model?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would cause exit - when they are using resume generator and not on open AI - which is clearly what we are as of now. as resume generator only supports open AI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surapuramakhil no, that is exactly why I opened #820. The logic is incomplete. This program always tries to upload a resume whether the flag is set or not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tgenz1213 explain current code behavior

  1. No resume is passed
  2. Resume generator won't be called because of LLM type

what would Agent submit? for resume

Copy link
Author

@Tgenz1213 Tgenz1213 Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option is: make --resume require an argument.

Let's please think about the basic functionality of a CLI app. No arguments = default behavior. Allowing --resume to have optional arguments is either wrong or misleading. Using --resume alone means it changes the default behavior to do "something." Using --resume with args changes the behavior of --resume.

#820 means to explain there's no behavior difference between "python main.py" and "python main.py --resume" when there should be.

Copy link
Collaborator

@49Simon 49Simon Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I've a couple of comments:

  1. Since this PR is supposed to be for formatting/styling the whole codebase, this commit should not have been included in this. It should be a separate PR addressing a separate issue.
  2. The --resume flag is supposed to require an argument. It is used when you want to use your own resume pdf file instead of having the bot generate a new resume for every application. I've checkout out to this PR, and --resume seems to work as expected:
Screenshot 2024-11-17 at 12 50 11 PM 3. In terms of fixing this issue (which should not be included in this PR), this commit will wait until the bot scrolls through jobs, select a job, scroll again, determine suitability, start filling forms and then find out it cant generate resume if you're not using OpenAI api. Instead, a better fix would be to have a check when a user runs `python main.py` and exit the app if they're not using OpenAI api by stating it wont be able to generate resume and they should apply with their own resume file by passing the flag. Because currently, it wont apply to any jobs if you're not providing your resume and you're not using OpenAI anyways.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@49Simon I stand corrected, at least for v4.1.0. There's a reason I thought --resume worked without args though. It might be an issue on main and I was keeping that in mind without double checking on this branch.

I'll revert the commit when I have a chance later and then double check my observations about behavior and other stuff. I'll work this issue and others separately. I just wanted to quickly remedy a bug while I noticed it. Next time I'll open a bug issue or mention it in an existing one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the resume, I just tested it on main and it still requires an argument. My understanding was it always required one tbh. If you find the instance where it allowed --resume flag without the file path, let me know.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! I will research this at my next availability.

self._create_and_upload_resume(element, job_context)
elif "cover" in output:
Expand Down