717 #734
717 #734
Conversation
Merge pull request AIHawk-FOSS#652 from feder-cr/release/v11.01.2024
Release/v11.15.2024
src/ai_hawk/linkedIn_easy_applier.py
Outdated
| @@ -466,8 +470,11 @@ def _create_and_upload_resume(self, element, job): | |||
|
|
|||
| while True: | |||
| try: | |||
| timestamp = int(time.time()) | |||
| file_path_pdf = os.path.join(folder_path, f"CV_{timestamp}.pdf") | |||
| file_path_pdf = os.path.join(folder_path, f"CV_{job.company}.pdf") | |||
There was a problem hiding this comment.
I feel correct name should be <cadidate_name>_coverletter.pdf for submission. for tacking (internal thing it can be job_tilte/id_converletter.pdf.
can you handle thls
There was a problem hiding this comment.
Also move it to a different method. something like get_cover_letter_name or similar.
There was a problem hiding this comment.
The candidate name does not seem to be easily accessible here
There was a problem hiding this comment.
including candidate name seems redundant doesn't it?
There was a problem hiding this comment.
it helps hiring companies. CV with candidate name is for uploading in job portal. They do get a bunch of CV files. more professional way
for tracking / logs of Job applicants it should be CV with job ID/details like company & position
|
When submitting a PR, you can also add a more detailed description of the changes to help us locate them quickly. |
|
not sarcastic is this a priority to spend time on? |
I think the UNIX time in the filename is important to take out because anti-bot operations could look for that |
💯 % |
src/ai_hawk/linkedIn_easy_applier.py
Outdated
| @@ -452,7 +452,11 @@ def _handle_upload_fields(self, element: WebElement, job) -> None: | |||
|
|
|||
| logger.debug("Finished handling upload fields") | |||
|
|
|||
| def _create_and_upload_resume(self, element, job): | |||
| def _create_resume_filepath(self,job:Job,folder_path:str,version:int)->str: | |||
| return os.path.join(folder_path, f"CV_{job.company}({version}).pdf") | |||
There was a problem hiding this comment.
why this function called create_resume when path is CV_
|
@FrancescoVassalli are you working on your PR? do you want someone to take over your PR? |
|
I will set aside some time to check this out |
|
I am digging into using this code to
|
|
@sarob @FrancescoVassalli hi, any updates about this? |
address #717