Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-1 #1038

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

search-1 #1038

wants to merge 8 commits into from

Conversation

ch20b063
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests / checks that you performed to verify your changes. Provide instructions so we can reproduce. Please delete options that are not relevant.

  • Tested the API endpoint on Swagger with the 'Try it out' feature
  • Tested the Models using the Django Shell
  • Any other tests you performed for checking edge cases.
  • Any other tests you performed for checking exceptions.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Checklist for Models

If you added new models / made changes to exsting models, please fill this checklist.

  • The primary key of the Model is an AutoField
  • I have defined the __str__ method for the Model
  • If the field is optional, it has been spcified explicitly
  • I have added a verbose_name for each Field.
  • I have added a docstring for the Model
  • The model is registered on Admin Site.
  • I have pushed the migrations.

Checklist for API

If you added new api endpoints / made changes to exsting endpoints, please fill this checklist.

  • The endpoint is accessible through Swagger.
  • The endpoint supports permissions and authentication for different roles.
  • All exceptions have been handled and appropriate status code is returned to the user.
  • I have added docstrings for ViewSets / Serializers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants