This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Use NSURLSession API to make it compatible with AFNetworking 3 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlu
reviewed
Sep 2, 2017
| @@ -32,7 +32,7 @@ | |||
| NSString * const AFAmazonS3EUCentral1Region = @"s3-eu-central-1.amazonaws.com"; | |||
| NSString * const AFAmazonS3APSoutheast1Region = @"s3-ap-southeast-1.amazonaws.com"; | |||
| NSString * const AFAmazonS3APSoutheast2Region = @"s3-ap-southeast-2.amazonaws.com"; | |||
| NSString * const AFAmazonS3APNortheast1Region = @"s3-ap-northeast-1.amazonaws.com"; | |||
| NSString * const AFAmazonS3APNortheast2Region = @"s3-ap-northeast-1.amazonaws.com"; | |||
There was a problem hiding this comment.
Why did you change the name on this constant?
There was a problem hiding this comment.
Check the header file, it's AFAmazonS3APNortheast2Region.
There was a problem hiding this comment.
ok, just curious, since the data center number doesn't match the constant. Since I have no affiliation with this, I don't really care.
Thanks for doing this, I will test this out if my client approves the upgrade to AFNetworking 3
There was a problem hiding this comment.
you're welcome! please feel free to comment if has any bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.