Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound library + fully clientsided sounds #378

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

thecraftianman
Copy link
Member

Closes #22 #34 #165 #347

  • Added a new sound library to network sounds to the client
  • Replaced all instances of sound playing with sound library uses
  • Fully clientsided all sounds
  • Removed the serverside volume setting
  • Added a volume setting to the sound replacer tool (controlled by the client CVar acfsound_volume)
  • Added sound pitch settings to guns and sound volume settings to guns/engines
  • Moved the function ACF.IsValidSound to ACF.Utilities.Sounds.IsValidSound

- Added a new sound library to network sounds to the client
- Replaced all instances of sound playing with sound library uses
- Fully clientsided all sounds
- Removed the serverside volume setting
- Added a volume setting to the sound replacer tool (controlled by acfsound_volume)
- Added sound pitch settings to guns and sound volume settings to guns/engines
- Moved the function ACF.IsValidSound to ACF.Utilities.Sounds.IsValidSound
@thecraftianman thecraftianman changed the base branch from dev to sound-lib January 19, 2024 23:55
@thecraftianman thecraftianman merged commit 4e12cc3 into ACF-Team:sound-lib Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant