Discuss this old branch #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for late reply. This branch is for the implementation of the BFwf with transformation (w.r.t. nuclei position) for the Hydrogen Chain example. However, it is just something quickly wrapped up and was not implemented nicely although it works fine and passes all the test. @DexuanZhou and I discussed about it and not sure where it should go to. Maybe we can clean this up and keep it as a separate file for now? Please let us know if you have any idea on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CheukHinHoJerry -- can you remind us of the role of this branch and what should be done with it?