Skip to content

Commit

Permalink
bc as regular scale, fix tests, fix vignettes for bc(), references #31
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryo-N7 committed Oct 22, 2019
1 parent 1b21b17 commit b682e2a
Show file tree
Hide file tree
Showing 12 changed files with 272 additions and 526 deletions.
423 changes: 171 additions & 252 deletions R/bulletchart.R

Large diffs are not rendered by default.

193 changes: 0 additions & 193 deletions R/bulletchart222.R

This file was deleted.

4 changes: 3 additions & 1 deletion R/globals.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
utils::globalVariables(c(".", "behind_by", "perc", "perc_week",
"perc_year", "percent_time", "text",
"tooltip", "tooltip2"))
"tooltip", "tooltip2",
"allvals", "vals", "data",
"plot", "Current", "tarhigh"))
2 changes: 1 addition & 1 deletion R/internal.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# internal functions ------------------------------------------------------

#' @title extra_field_calculator
#' @title Field calculator for time-constraint scale
#' @description internal function for calculating the extra fields needed for bullet charts
#' @param file_name path of Excel file
#' @param sheet_name specify which sheet in Excel file
Expand Down
2 changes: 1 addition & 1 deletion R/internal2.R → R/internal_bc.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# internal functions ------------------------------------------------------

#' @title extra_field_calculator
#' @title Field calculator for regular scale
#' @description internal function for calculating the extra fields needed for bullet charts
#' @param file_name path of Excel file
#' @param sheet_name specify which sheet in Excel file
Expand Down
56 changes: 22 additions & 34 deletions man/bullet_chart.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/extra_field_calculator.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/field_calculator.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b682e2a

Please sign in to comment.