-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
um7: depend on oasis3-mct branch access-esm1.5 #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comparison ACCESS-NRI/oasis3-mct@access-esm1.5...ACCESS-NRI:oasis3-mct:access-esm1.5-new-modules shows non-trivial differences between the two branches. Are each of these differences intended, and what are their purpose?
Additionally, my first attempts at installation failed:
|
Hi @penguian , I've updated the |
|
* Thanks to Paul Leopardi for this suggestion.
* Use oasis3-mct's new version label for branch access-esm1.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ruff checks should be addressed. If we're not using pprint
then we shouldn't import it. The f-string errors are just pointing out that there are no variable interpolations in those strings, so they can just be simple strings without the f
.
Hi @aidanheerdegen , Will address linter issues when adding support for oneapi compilers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to leave linter changes for now.
No description provided.