Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding required COSIMA/spack_packages packages, access-om3 SBD rename #92

Closed
wants to merge 3 commits into from

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Apr 17, 2024

In this PR:

  • Added the COSIMA/spack_packages packages required for the OM3 spack.yaml - fms, fortranxml at COSIMA/spack_packages@a65eaf4
  • Renamed SBD from access-om3-virtual to access-om3
  • Renamed SPD from access-om3 to access-om3-cmakeaccess-om3--nuopc (Open to changing this name. This also may affect some COSIMA stuff, so I'd like to get @micaeljtoliveira to review and approve)

Tagging @aidanheerdegen as well.

Closes #91

@CodeGat CodeGat self-assigned this Apr 17, 2024
@harshula
Copy link
Collaborator

Hi, Describing function in an SPD name is probably better than referring to its build system. i.e. Can the access-om3-cmake suffix describe something other than its build system? e.g. access-om3-nuopc.

@CodeGat
Copy link
Contributor Author

CodeGat commented Apr 17, 2024

Closing this as it has been split into two PRs as per @harshula request:

@CodeGat CodeGat closed this Apr 17, 2024
@CodeGat CodeGat deleted the 91-cosima-om3-packages branch April 17, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy required packages from COSIMA/spack_packages, rename root access-om3 SBD
2 participants